Exclude Windows from the bundled remote-auth server build - #2
Open
bobvh wants to merge 1 commit into
Open
Conversation
struct DoltliteServer in the doltlite.c amalgamation uses raw POSIX pthread_t/pthread_mutex_t/pthread_cond_t with no Windows implementation, so MSVC fails to parse the struct (and every later use of it cascades into "undefined struct" errors). Windows builds are client-only and don't need to host the embedded remote-auth TCP server, so exclude Windows from remote_supported the same way wasm32 already is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for the windows builds of the Python wheels when we include the client in there as well (PR220 on gen).
I assume that no one on windows will want to be running a doltlite server anyway, just like the wasm exclusion on the same.
Technical description: